Escaping Ignore Patterns

Rewt0r · February 17, 2015, 10:24pm

I’ve noticed that our nodes are syncing Office temporary files so I’ve decided to start using Ignore Patterns. I’ve read the Wiki over at: https://github.com/syncthing/syncthing/wiki/Ignoring-Files however I can’t seem to get it working.

My .stignore contains: #include .stignorepatterns

The patterns I’ve added to .stignorepatterns are:

~$.doc ~$.docx ~$.ppt ~$.pptx ~$.xls ~$.xlsx

I’ve also tried them with a backslash in front of the ~ and $ characters and it still isn’t working.

Any ideas?

AudriusButkevicius · February 18, 2015, 12:09am

I think you might only need to escape the $

Rewt0r · February 18, 2015, 1:05am

I’ve tried that @AudriusButkevicius. I’ve tried escaping both characters individually and together.

AudriusButkevicius · February 18, 2015, 10:05am

Yeah, I don’t know then. You can probably write a test case and make a pull request fixing it, relevant parts here:

github.com

syncthing/syncthing/blob/2fa45436c29fb5baad2b9f3dfe2e7ae3714b242c/internal/ignore/ignore_test.go#L60




		{"dir2", false},
		{filepath.Join("dir2", "cfile"), false},
		{filepath.Join("dir2", "dfile"), true},
		{filepath.Join("dir2", "efile"), true},
		{filepath.Join("dir2", "ffile"), false},


		{filepath.Join("dir3"), true},
		{filepath.Join("dir3", "afile"), true},


		{"lost+found", true},
	}


	for i, tc := range tests {
		if r := pats.Match(tc.f); r != tc.r {
			t.Errorf("Incorrect ignoreFile() #%d (%s); E: %v, A: %v", i, tc.f, tc.r, r)
		}
	}
}


func TestExcludes(t *testing.T) {

github.com

syncthing/syncthing/blob/996cbbca386466cd4aa62a2c441c8a836bce99cd/internal/ignore/testdata/.stignore

#include excludes

bfile
dir1/cfile
**/efile
/ffile
lost+found

and

https://github.com/syncthing/syncthing/blob/master/internal/fnmatch/fnmatch.go#L53

But I feel that this also might be a windows only thing.

calmh · February 19, 2015, 7:03am

I think this is a bug. The matcher converts the glob patterns to regexps, but doesn’t escape $, ^ and probably some more characters that are special in regexps but not in globs. You should be able to work around it by throwing either one or two \ in front of the dollar sign…

calmh · February 19, 2015, 7:11am

Fixed

Rewt0r · February 19, 2015, 7:12am

Thanks @calmh