Syncthing v1.8.0-rc.2 bug: Versioning configuration is reset

Catfriend1 · July 28, 2020, 9:47am

Hi,

my versioning configuration was reset during my cluster upgraded from v1.7.1 to v1.8.0-rc.2 (config scheme 30 to 31).

My git documentation shows the difference:

I suspect a bug maybe here or a missing migration?

Kind regards, Catfriend1

calmh · July 28, 2020, 9:49am

Yeah looks like a screwup, mind filing it?

Catfriend1 · July 28, 2020, 9:58am

I’m now trying to reproduce it, it does NOT reproduce when upgrading from a fresh v1.7.1 to v1.8.0-rc.2.

Before:

After:

calmh · July 28, 2020, 9:59am

The internalVersioningConfiguration stuff is the bug, it shouldn’t be exposed. There should be no format change from 1.7.x.

Catfriend1 · July 28, 2020, 10:03am

Ok, it’s very weird. I’ve setup v1.6.1, applied versioning config, updated to v1.8.0-rc.2 and didn’t lose my versioning config. It was migrated to the internalVersioningConfiguration block including the 90 days interval I had set before.

From my point of view, the reproducer is missing and this can be closed. If you have already found something wrong, I’m all ears ;).

calmh · July 28, 2020, 10:04am

Thanks, got the bug. You’ll lose versioning config again from 1.8.0-rc.2 to the fixed 1.8.0-rc.3, unfortunately.

Catfriend1 · July 28, 2020, 12:08pm

Thank you for fixing it

ref: lib/config: Repair versioning XML serialization (fixes #6859, ref #6693) · syncthing/syncthing@4faa588 · GitHub

system · August 27, 2020, 12:08pm

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.