Syncthing v1.8.0-rc.2 bug: Versioning configuration is reset

Hi,

my versioning configuration was reset during my cluster upgraded from v1.7.1 to v1.8.0-rc.2 (config scheme 30 to 31).

My git documentation shows the difference:

image

image

I suspect a bug maybe here or a missing migration?

Kind regards, Catfriend1

Yeah looks like a screwup, mind filing it?

I’m now trying to reproduce it, it does NOT reproduce when upgrading from a fresh v1.7.1 to v1.8.0-rc.2.

Before:

image

After:

image

The internalVersioningConfiguration stuff is the bug, it shouldn’t be exposed. There should be no format change from 1.7.x.

Ok, it’s very weird. I’ve setup v1.6.1, applied versioning config, updated to v1.8.0-rc.2 and didn’t lose my versioning config. It was migrated to the internalVersioningConfiguration block including the 90 days interval I had set before.

From my point of view, the reproducer is missing and this can be closed. If you have already found something wrong, I’m all ears ;).

Thanks, got the bug. You’ll lose versioning config again from 1.8.0-rc.2 to the fixed 1.8.0-rc.3, unfortunately.

2 Likes

Thank you for fixing it :slight_smile: :+1:

ref: https://github.com/syncthing/syncthing/commit/4faa5882f2142b5b3980ecc7011a2bd50cc03799

1 Like