Possible panic: bug:

Hello,

I’m getting:

panic: bug: tried to put impossible block cap 198751

goroutine 328 [running]:
github.com/syncthing/syncthing/lib/protocol.putBucketForCap(0x3085f, 0xc0036da3c0)
        /home/rah/go/src/github.com/syncthing/syncthing/lib/protocol/bufferpool.go:111 +0xe6
github.com/syncthing/syncthing/lib/protocol.(*bufferPool).Put(0x16ca820, 0xc00525c000, 0x1219d, 0x3085f)
        /home/rah/go/src/github.com/syncthing/syncthing/lib/protocol/bufferpool.go:68 +0xa8
github.com/syncthing/syncthing/lib/protocol.(*rawConnection).writeCompressedMessage(0xc003d91c70, 0x10eb620, 0xc0037177d0, 0x1, 0x3)
        /home/rah/go/src/github.com/syncthing/syncthing/lib/protocol/protocol.go:734 +0x54a
github.com/syncthing/syncthing/lib/protocol.(*rawConnection).writeMessage(0xc003d91c70, 0x10eb620, 0xc0037177d0, 0x0, 0x1)
        /home/rah/go/src/github.com/syncthing/syncthing/lib/protocol/protocol.go:695 +0x6c
github.com/syncthing/syncthing/lib/protocol.(*rawConnection).writerLoop(0xc003d91c70)
        /home/rah/go/src/github.com/syncthing/syncthing/lib/protocol/protocol.go:673 +0x307
created by github.com/syncthing/syncthing/lib/protocol.(*rawConnection).Start
        /home/rah/go/src/github.com/syncthing/syncthing/lib/protocol/protocol.go:237 +0x87

On a git bisect, this seems to have been introduced by:

commit 6755a9ca63b25cd53f1e8b8bbd19ca199aef00d7
Author: Jakob Borg <jakob@kastelo.net>
Date:   Wed Nov 6 11:53:10 2019 +0100

    Fix bufferpool puts (ref #4976) (#6125)

I’m running the github version on Linux x86_64:

Linux Kernel: 4.19.82 
Glibc: 2.30
Go: 1.13.3

Two androids and one Mac also in test cluster.

Let me know if you need extended logs.

Thanks for your continued work on syncthing - I love it.

Cheers,

===Rich

2 Likes

Can you open an issue on github?

I’ve seen a bunch of these on sentry.

@rahrah Thanks for bringing it to our attention!

1 Like

So no action required of me, right?

Thanks,

===R

Nope. Upgrade to 1.3.2-rc.1 or thereabouts for the fix, otherwise not. :slight_smile:

Thanks! :slight_smile:

===R