I’ve gone through the code and fixed a bunch of linter complaints, some of them hiding actual bugs.
Additionally there is now a new cloud based lint check that will comment and complain on pull requests. It’s smart enough to only bring up stuff that actually is a result from the pull request, not old existing crap.
Some of the stuff it reports is really good and should be fixed directly.
There are also things we can ignore - like the
errcheck in some cases, and probably others. However I’m not going to disable the checks, instead use human judgement in ignoring or fixing its suggestions. So a red mark from GolangCI shouldn’t be taken as a complete blocker, but something to note and look at as a human.