File watcher on Windows sometimes stops working for specific folders

bt90 · August 16, 2021, 5:40am

Isn’t this the bug fixed by @imsodin ?

github.com/rjeczalik/notify

Fixes for non-recursive tree when dirs are deleted (fixes #200)

rjeczalik:master ← syncthing:fix-200

opened 09:19PM - 09 Feb 21 UTC

imsodin

+98 -15

I added a test based on the example posted in #200. The main change is to als…o pass `Remove` events to `t.rec`, and then unwatch and delete nodes under that path. Thus when it gets created again, new watches will be set up (instead of keeping the old, now invalid watches). I also fixed some stuff I encountered while debugging and fixing: - go.mod always changes when running anything like tests. I chose 1.11 because that's when modules started - earlier versions anyway don't care about go.mod. - Don't re-add already existing created directories - that lead to empty leave nodes (however shouldn't happen any more now that deleted dirs are removed - still better be safe). - `indexbase` is needlessly complicated. All functions where it is called return an error if the root and name are equal. I thus chaned it to return `-1` if `root` and `name` are equal. And renamed it to `indexrel`, as it's the first index of the path relative to root, not the last element in name.

Looks like syncthings fork of the library already got updated but syncthing still uses an older version of it:

github.com

syncthing/syncthing/blob/a5bbb500e62c3742ef0860a9f21395575a1162b9/go.mod#L44

    
      
          	github.com/minio/sha256-simd v1.0.0
          	github.com/miscreant/miscreant.go v0.0.0-20200214223636-26d376326b75
          	github.com/oschwald/geoip2-golang v1.5.0
          	github.com/petermattis/goid v0.0.0-20180202154549-b0b1615b78e5 // indirect
          	github.com/pkg/errors v0.9.1
          	github.com/prometheus/client_golang v1.10.0
          	github.com/rcrowley/go-metrics v0.0.0-20201227073835-cf1acfcdf475
          	github.com/russross/blackfriday/v2 v2.1.0 // indirect
          	github.com/sasha-s/go-deadlock v0.2.0
          	github.com/shirou/gopsutil/v3 v3.21.4
          	github.com/syncthing/notify v0.0.0-20210308121556-f45149b04939
          	github.com/syndtr/goleveldb v1.0.1-0.20200815071216-d9e9293bd0f7
          	github.com/thejerf/suture/v4 v4.0.1
          	github.com/urfave/cli v1.22.5
          	github.com/vitrun/qart v0.0.0-20160531060029-bf64b92db6b0
          	golang.org/x/crypto v0.0.0-20210711020723-a769d52b0f97
          	golang.org/x/net v0.0.0-20210716203947-853a461950ff
          	golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c
          	golang.org/x/text v0.3.6
          	golang.org/x/time v0.0.0-20210220033141-f8bda1e9f3ba
          	golang.org/x/tools v0.1.5

Edit: the fork already has this fix:

github.com/syncthing/notify

Fixes for non-recursive tree when dirs are deleted

syncthing:main ← syncthing:fix-200-syncthing

opened 12:07PM - 08 Mar 21 UTC

imsodin

+98 -15

This fixes https://github.com/rjeczalik/notify/issues/200. PR upstream unfor…tunately hasn't seen a reaction yet: https://github.com/rjeczalik/notify/pull/201 It's an issue that is might to lead to an actually worse user experience (some directories not being watched), thus I'd like to merge this already now to get it into the next Syncthing release. I still do expect it to be merged upstream at some points, past contributions usually were (in time).